From 9ef7072397457e8cdb8a63a1a6953d01f46b2904 Mon Sep 17 00:00:00 2001 From: Mukund Keshava Date: Tue, 27 May 2025 20:24:15 +0530 Subject: Add check for subscript operator return type (#7244) Fixes #6987 --- source/slang/slang-check-decl.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'source/slang/slang-check-decl.cpp') diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index 7a0dcb06f..f8a80c09b 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -10405,7 +10405,16 @@ void SemanticsDeclHeaderVisitor::visitAbstractStorageDeclCommon(ContainerDecl* d void SemanticsDeclHeaderVisitor::visitSubscriptDecl(SubscriptDecl* decl) { - decl->returnType = CheckUsableType(decl->returnType, decl); + // __subscript needs to have a return type specified. Check if return type + // is missing (represented as IncompleteExpr) and return an error. + if (decl->returnType.exp && as(decl->returnType.exp)) + { + getSink()->diagnose(decl, Diagnostics::subscriptMustHaveReturnType); + } + else if (decl->returnType.exp) + { + decl->returnType = CheckUsableType(decl->returnType, decl); + } visitAbstractStorageDeclCommon(decl); -- cgit v1.2.3