From 8102e5ee81db177372bb90188c65d003a4907aa4 Mon Sep 17 00:00:00 2001 From: Yong He Date: Wed, 6 Dec 2023 15:52:02 -0800 Subject: Change default visibility of interface members and update docs. (#3381) * Update behavior around interfaces and docs. * Update toc --------- Co-authored-by: Yong He --- source/slang/slang-check-decl.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'source/slang/slang-check-decl.cpp') diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp index 671bb26dd..39f0b9096 100644 --- a/source/slang/slang-check-decl.cpp +++ b/source/slang/slang-check-decl.cpp @@ -4059,7 +4059,19 @@ namespace Slang continue; if (doesMemberSatisfyRequirement(member.declRef, requiredMemberDeclRef, witnessTable)) + { + // The member satisfies the requirement in every other way except that + // it may have a lower visibility than min(parentVisibility, requirementVisibilty), + // in that case we will treat it as an error. + auto minRequiredVisibility = Math::Min(getDeclVisibility(requiredMemberDeclRef.getDecl()), getTypeVisibility(subType)); + if (getDeclVisibility(member.declRef.getDecl()) < minRequiredVisibility) + { + getSink()->diagnose(member.declRef, Diagnostics::satisfyingDeclCannotHaveLowerVisibility, member.declRef); + getSink()->diagnose(requiredMemberDeclRef, Diagnostics::seeDeclarationOf, QualifiedDeclPath(requiredMemberDeclRef)); + return false; + } return true; + } } // If we reach this point then there were no members suitable -- cgit v1.2.3