From e8217c70072080e9d1f499cb670cc08f146818f2 Mon Sep 17 00:00:00 2001
From: Julius Ikkala <julius.ikkala@gmail.com>
Date: Fri, 10 Jan 2025 03:24:00 +0200
Subject: Fix implicit string conversion breaking NativeStrings (#6035)

* Fix implicit string conversion breaking NativeStrings

* Allow string literals to coerce to either string type

* Add test for CPU string passing

---------

Co-authored-by: Yong He <yonghe@outlook.com>
---
 source/slang/slang-check-conversion.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'source/slang/slang-check-conversion.cpp')

diff --git a/source/slang/slang-check-conversion.cpp b/source/slang/slang-check-conversion.cpp
index 7cb71a1bd..248c83fe5 100644
--- a/source/slang/slang-check-conversion.cpp
+++ b/source/slang/slang-check-conversion.cpp
@@ -785,8 +785,8 @@ bool SemanticsVisitor::_coerce(
         return true;
     }
 
-    // If both are string types we assume they are convertable in both directions
-    if (as<StringTypeBase>(fromType) && as<StringTypeBase>(toType))
+    // Assume string literals are convertible to any string type.
+    if (as<StringLiteralExpr>(fromExpr) && as<StringTypeBase>(toType))
     {
         if (outToExpr)
             *outToExpr = fromExpr;
-- 
cgit v1.2.3