From b7d318f48db2cb83a41d665f1727ae93fc555124 Mon Sep 17 00:00:00 2001 From: Yong He Date: Thu, 28 Sep 2023 18:07:40 -0700 Subject: Support `constref` parameters passing. (#3249) * Support `constref` parameters passing. * Fix. * Fix. * Add test and diagnostic on mix use of __constref and no_diff. * check for [constref] on differentiable member method. --------- Co-authored-by: Yong He --- source/slang/slang-check-conversion.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'source/slang/slang-check-conversion.cpp') diff --git a/source/slang/slang-check-conversion.cpp b/source/slang/slang-check-conversion.cpp index c4efba658..c2cfabcfe 100644 --- a/source/slang/slang-check-conversion.cpp +++ b/source/slang/slang-check-conversion.cpp @@ -991,11 +991,12 @@ namespace Slang return true; } - if (auto refType = as(toType)) + if (auto refType = as(toType)) { - if (!refType->getValueType()->equals(fromType)) + ConversionCost cost; + if (!canCoerce(refType->getValueType(), fromType, fromExpr, &cost)) return false; - if (!fromExpr->type.isLeftValue) + if (as(toType) && !fromExpr->type.isLeftValue) return false; ConversionCost subCost = kConversionCost_GetRef; @@ -1016,7 +1017,7 @@ namespace Slang // Allow implicit dereferencing a reference type. - if (auto fromRefType = as(fromType)) + if (auto fromRefType = as(fromType)) { auto fromValueType = fromRefType->getValueType(); -- cgit v1.2.3