From 7758625d3fea67e55e98e7e4103d56c9918365be Mon Sep 17 00:00:00 2001
From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com>
Date: Fri, 29 Aug 2025 15:52:34 -0700
Subject: [CBP] Pointer frontend changes + groupshared pointer support (#7848)

Resolves #7628
Resolves: #8197

Primary Goals:
1. Add `Access` to pointer
2. AddressSpace::GroupShared support for pointers (SPIR-V)
3. Add `__getAddress()` to replace `&`
* `&` is not updated to `require(cpu)` since slangpy uses `&`. This
means we must: (1) merge PR; (2) replace `&` with `__getAddress()`; (3)
add `require(cpu)` to `&`

Changes:
* Added to `Ptr` the `Access` generic argument & logic (for
`Access::Read`).
* Moved the generic argument `AddressSpace` from `Ptr` to the end of the
type.
* Added pointer casting support between any `Ptr` as long as the
`AddressSpace` is the same
* Disallow globallycoherent T* and coherent T*
* Disallow const T*, T const*, and const T*
* Fixed .natvis display of `ConstantValue` `ValOperandNode`
* Support generic resolution of type-casted integers
* Added `VariablePointer` emitting for spirv + other minor logic needed
for groupshared pointers

Breaking Changes:
* Anyone using the `AddressSpace` of `Ptr` will now have to account for
the `Access` argument
* we disallow various syntax paired with `Ptr` and `T*`

---------

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
---
 source/slang/slang-check-conversion.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'source/slang/slang-check-conversion.cpp')

diff --git a/source/slang/slang-check-conversion.cpp b/source/slang/slang-check-conversion.cpp
index 758c23a5f..4d15fd840 100644
--- a/source/slang/slang-check-conversion.cpp
+++ b/source/slang/slang-check-conversion.cpp
@@ -1760,6 +1760,13 @@ bool SemanticsVisitor::_coerce(
             if (sink)
             {
                 sink->diagnose(fromExpr, Diagnostics::ambiguousConversion, fromType, toType);
+                for (auto candidate : overloadContext.bestCandidates)
+                {
+                    sink->diagnose(
+                        candidate.item.declRef,
+                        Diagnostics::seeDeclarationOf,
+                        candidate.item.declRef);
+                }
             }
 
             *outToExpr = CreateErrorExpr(fromExpr);
-- 
cgit v1.2.3