From ce879112cb16e3def1b8673104e7123b8b17ee2a Mon Sep 17 00:00:00 2001 From: Yong He Date: Sun, 21 Jan 2018 07:09:55 -0500 Subject: Improvements and bug fixes for global type parameters 1. allow spReflection_FindTypeByName to accept arbitrary type expression string 2. allow const int generic value to be used as expression value, and as array size 3. various bug fixes in witness table specialization / function cloning during specializeIRForEntryPoint to avoid creating duplicate global values, not copying the right definition of a function from the other module, not cloning witness tables that are required by specializeGenerics etc. --- source/slang/reflection.cpp | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) (limited to 'source/slang/reflection.cpp') diff --git a/source/slang/reflection.cpp b/source/slang/reflection.cpp index c9de75d6e..b0be58274 100644 --- a/source/slang/reflection.cpp +++ b/source/slang/reflection.cpp @@ -433,20 +433,8 @@ SLANG_API SlangReflectionType * spReflection_FindTypeByName(SlangReflection * re auto context = convert(reflection); auto compileRequest = context->targetRequest->compileRequest; - RefPtr result; - if (compileRequest->types.TryGetValue(name, result)) - return (SlangReflectionType*)result.Ptr(); - - auto nameObj = compileRequest->getNamePool()->getName(name); - Decl* resultDecl = compileRequest->lookupGlobalDecl(nameObj); - if (resultDecl) - { - RefPtr declRefType = new DeclRefType(); - declRefType->declRef.decl = resultDecl; - compileRequest->types[name] = declRefType; - return (SlangReflectionType*)declRefType.Ptr(); - } - return nullptr; + RefPtr result = compileRequest->getTypeFromString(name); + return (SlangReflectionType*)result.Ptr(); } SLANG_API SlangReflectionTypeLayout* spReflection_GetTypeLayout( -- cgit v1.2.3