From cfb1f61d478c92026718cedca4bfec8c2afc1b00 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Tue, 13 Nov 2018 17:02:27 -0500 Subject: * Fix bug outputing dxbc assembly (#719) * Make the disassembly methods returns SlangResult and String as last output param so as to make error case clear. --- source/slang/dxc-support.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'source/slang/dxc-support.cpp') diff --git a/source/slang/dxc-support.cpp b/source/slang/dxc-support.cpp index 152710534..b00583f10 100644 --- a/source/slang/dxc-support.cpp +++ b/source/slang/dxc-support.cpp @@ -270,11 +270,9 @@ namespace Slang ComPtr dxcResultBlob; SLANG_RETURN_ON_FAIL(dxcCompiler->Disassemble(dxcSourceBlob, dxcResultBlob.writeRef())); - String result; char const* codeBegin = (char const*)dxcResultBlob->GetBufferPointer(); char const* codeEnd = codeBegin + dxcResultBlob->GetBufferSize() - 1; - result.append(codeBegin, codeEnd); - stringOut = result; + stringOut = String(codeBegin, codeEnd); return SLANG_OK; } -- cgit v1.2.3