From d3331fba6eaab44646010b556106da38925d43e0 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Thu, 6 Feb 2020 14:31:09 -0500 Subject: Literal handling improvements (#1202) * WIP: 64 literal diagnostic and truncation. * Improve how integer truncation is handled/supported. Added literal-int64.slang test. Set a suffix on all literals. Fixed problem on C++ based targets where l suffix was not the same as int() cast. So on C++ derived emitters, int() is used instead of l suffix to have same behavior across targets. * Add literal diagnostic testing. * Allow lexer to lex - in front of literals. * Fix lexing and converting int literal with -. * Too large small values of floats become inf. Handling writing inf types out on different targets. Add function to deterimine if a float literals kind. * Roll back the support of lexer lexing negative literals. * Fixed tests broken because of diagnostics numbers. Improved _isFinite * Fix compilation on linux. * Fix problem with abs on linux - use Math::Abs. * Fix typo. * * Improve warnings for float literals zeroed * Improved 64 bit type documentation * Handle half * Improved comments * Fixed tests broken * Use capital letters for suffixes. * Make default behavior on outputting a int literal that is an 'int32_t' is cast (not suffix) to avoid platform inconsistencies. Improve documentation for 64 bit types. Make tests cover material in docs. * Fixed tests. * Rename FloatKind::Normal -> Finite * Fix half zero check. --- source/core/slang-math.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'source/core') diff --git a/source/core/slang-math.h b/source/core/slang-math.h index 0daad0d5a..fa7eea6be 100644 --- a/source/core/slang-math.h +++ b/source/core/slang-math.h @@ -5,6 +5,13 @@ namespace Slang { + // Some handy constants + + // The largest positive (or negative) number +# define SLANG_HALF_MAX 65504.0f + // Smallest (denormalized) value. 1 / 2^24 +# define SLANG_HALF_SUB_NORMAL_MIN (1.0f / 16777216.0f) + class Math { public: @@ -20,6 +27,13 @@ namespace Slang static const float Pi; + + template + static T Abs(T a) + { + return (a < 0) ? -a : a; + } + template static T Min(const T& v1, const T&v2) { -- cgit v1.2.3