From b1369040c3d6d6a8704bdb17d9de99f36a108e07 Mon Sep 17 00:00:00 2001 From: jsmall-nvidia Date: Tue, 26 May 2020 13:53:10 -0400 Subject: Improvements around hashing (#1355) * Fields from upper to lower case in slang-ast-decl.h * Lower camel field names in slang-ast-stmt.h * Fix fields in slang-ast-expr.h * slang-ast-type.h make fields lowerCamel. * slang-ast-base.h members functions lowerCamel. * Method names in slang-ast-type.h to lowerCamel. * GetCanonicalType -> getCanonicalType * Substitute -> substitute * Equals -> equals ToString -> toString * ParentDecl -> parentDecl Members -> members * * Make hash code types explicit * Use HashCode as return type of GetHashCode * Added conversion from double to int64_t * Split Stable from other hash functions * toHash32/64 to convert a HashCode to the other styles. GetHashCode32/64 -> getHashCode32/64 GetStableHashCode32/64 -> getStableHashCode32/64 * Other Get/Stable/HashCode32/64 fixes * GetHashCode -> getHashCode * Equals -> equals * CreateCanonicalType -> createCanonicalType * Catches of polymorphic types should be through references otherwise slicing can occur. * Fixes for newer verison of gcc. Fix hashing problem on gcc for Dictionary. * Another fix for GetHashPos * Fix signed issue around GetHashPos --- source/core/slang-string.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'source/core/slang-string.h') diff --git a/source/core/slang-string.h b/source/core/slang-string.h index 5eb113dc1..02a43a806 100644 --- a/source/core/slang-string.h +++ b/source/core/slang-string.h @@ -170,9 +170,9 @@ namespace Slang UnownedStringSlice trim() const; - int GetHashCode() const + HashCode getHashCode() const { - return Slang::GetHashCode(m_begin, size_t(m_end - m_begin)); + return Slang::getHashCode(m_begin, size_t(m_end - m_begin)); } template @@ -802,9 +802,9 @@ namespace Slang return contains(str.begin()); } - int GetHashCode() const + HashCode getHashCode() const { - return Slang::GetHashCode((const char*)begin()); + return Slang::getHashCode(StringRepresentation::asSlice(m_buffer)); } UnownedStringSlice getUnownedSlice() const -- cgit v1.2.3