From 66b103180e168c597f3c246c68a9886b69707493 Mon Sep 17 00:00:00 2001 From: Ellie Hermaszewska Date: Wed, 16 Oct 2024 00:38:39 +0800 Subject: Move C interface from slang.h to slang-deprecated.h (#5301) * Squash redundant move warnings * Move C interface from slang.h to slang-deprecated.h spGetBuildTagString remains, because it's useful to have before the global session exists. This C API is used quite pervasively in the C++ helpers (for example slang::UserAttribute. It's not trivial to move these to slang-deprecated.h as they're entangled with some enums which are themselves used elsewhere in the compiler. The fact that these helpers use the C API can be viewed as an implementation detail for now, and this usage moved to slang-deprecated in due course. Closes https://github.com/shader-slang/slang/issues/4758 * Squash warnings for our usage of our deprecated API --------- Co-authored-by: Yong He --- source/core/slang-string-util.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source/core/slang-string-util.cpp') diff --git a/source/core/slang-string-util.cpp b/source/core/slang-string-util.cpp index c7625e1e0..79f7307dc 100644 --- a/source/core/slang-string-util.cpp +++ b/source/core/slang-string-util.cpp @@ -332,7 +332,7 @@ UnownedStringSlice StringUtil::getAtInSplit(const UnownedStringSlice& in, char s append(format, args, builder); va_end(args); - return std::move(builder); + return builder; } /* static */UnownedStringSlice StringUtil::getSlice(ISlangBlob* blob) @@ -384,7 +384,7 @@ ComPtr StringUtil::createStringBlob(const String& string) } builder.appendInPlace(dstChars, numChars); - return std::move(builder); + return builder; } /* static */String StringUtil::calcCharReplaced(const String& string, char fromChar, char toChar) -- cgit v1.2.3