From 07f21ee31b5f427edb72d5578f713b3da3f3b96f Mon Sep 17 00:00:00 2001 From: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Date: Fri, 8 Aug 2025 13:19:25 -0700 Subject: Error if super-type capabilities are a super-set of sub-type (#7452) Fixes: #7410 Changes: 1. super-type capabilities must be a super-set of sub-type capabilities (and support the same shader stages/targets) * InheritanceDecl visits super-type to inherit it's capabilities; validate InheritanceDecl capabilities against sub-type * visit all container decl's with a default case * clean up functionDeclBase visitor * Simplify `diagnoseUndeclaredCapability` by moving logic into capability checking (more correct*) 3. added changed behavior to documentation 4. fixed some incorrect capabilities 5. **we do not** diagnose capability errors on interface requirement-to-implementation if both lack explicit capability requirements. This change is to work around a slangpy regression (test case for the failing situation is in `tests\language-feature\capability\capability-interface-extension-1.slang`), Note: maybe for slang-2026 we don't do this? 6. requirement & implementation must support the same shader stage/target. This was changed because otherwise we can have cases where `X` inherits from `Y`, but `Y` is only expected to be used in `glsl` whilst `X` is expected to be used in `hlsl | glsl` 7. removed `tests/language-feature/capability/capabilitySimplification3.slang` because it tests nothing special (redundant) Note: not using rebase due to separate branches depending on this PR --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- docs/command-line-slangc-reference.md | 1 + 1 file changed, 1 insertion(+) (limited to 'docs/command-line-slangc-reference.md') diff --git a/docs/command-line-slangc-reference.md b/docs/command-line-slangc-reference.md index 95a13a263..cf858a54c 100644 --- a/docs/command-line-slangc-reference.md +++ b/docs/command-line-slangc-reference.md @@ -1360,6 +1360,7 @@ A capability describes an optional feature that a target may or may not support. * `GL_NV_shader_subgroup_partitioned` : enables the GL_NV_shader_subgroup_partitioned extension * `GL_NV_shader_texture_footprint` : enables the GL_NV_shader_texture_footprint extension * `GL_NV_cluster_acceleration_structure` : enables the GL_NV_cluster_acceleration_structure extension +* `GL_NV_cooperative_vector` : enables the GL_NV_cooperative_vector extension * `nvapi` * `raytracing` * `ser` -- cgit v1.2.3