From 4fa76f374c0c35c9c7d186e8addf6861e98baaec Mon Sep 17 00:00:00 2001 From: cheneym2 Date: Tue, 5 Nov 2024 17:28:36 -0500 Subject: Catch all exceptions in render-test (#5495) Catch all exceptions in render-test In MSVC, the /EHsc flag is used by default, it causes only C++ (synchronous) exceptions to be caught by try/catch blocks. The /EHa flag can instead be used to catch both synchronous C++ exceptions as well as structured asynchronous exceptions such as those seen in segfaults or other typical bugs. Using /EHa allows render-test to not crash completely if there is a buggy graphics driver in the system. Issue 5275 --- cmake/SlangTarget.cmake | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'cmake/SlangTarget.cmake') diff --git a/cmake/SlangTarget.cmake b/cmake/SlangTarget.cmake index 4a3b75704..98517a1ba 100644 --- a/cmake/SlangTarget.cmake +++ b/cmake/SlangTarget.cmake @@ -337,9 +337,10 @@ function(slang_add_target dir type) ) endif() if(ARG_EXTRA_COMPILE_OPTIONS_PRIVATE) - target_compile_options( + add_supported_cxx_flags( ${target} - PRIVATE ${ARG_EXTRA_COMPILE_OPTIONS_PRIVATE} + PRIVATE + ${ARG_EXTRA_COMPILE_OPTIONS_PRIVATE} ) endif() -- cgit v1.2.3