From edb7289383538c3356ca2d5f7c37f41821bbf252 Mon Sep 17 00:00:00 2001 From: Gangzheng Tong Date: Mon, 7 Apr 2025 01:09:02 -0700 Subject: Use GITHUB_TOKEN for fetching prebuilt (#6712) * Use GITHUB_TOKEN for fetching prebuilt This PR extends Commit c6b702c to use GITHUB_TOKEN if set for fetching prebuilt binaries. This allows webgpu-dawn and slang-tint to be downloaded for certain IPs where the github API rate is limited. Fixes #6689 * Don't ignore download failure if github token is provided * Update readme for getting github access token * format code * combine cmake_parse_arguments calls * format code --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Co-authored-by: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Co-authored-by: Ellie Hermaszewska --- CONTRIBUTING.md | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 822d44f08..36d297214 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -170,15 +170,11 @@ Call Stack (most recent call first): CMakeLists.txt:141 (get_best_slang_binary_release_url) ``` -The limit is higher when you use your personal account with a "Passkey". +The limit is higher when you use your personal account with a "personal access token". -To generate a "Passkey" on GitHub: - 1. Go to GitHub "Settings" for your account. - 2. Go to "Password and Authentication". - 3. Click "Add a passkey" button. - 4. GitHub will generate a "Passkey". +To generate a "personal access token" on GitHub, follow steps in [Creating a personal access token (classic)](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-personal-access-token-classic) -Use the generated "Passkey" with a cmake option "-DSLANG_GITHUB_TOKEN=your-pass-key-here". +Use the generated "token" with a cmake option "-DSLANG_GITHUB_TOKEN=your-token-here". ### Making Changes Make your changes and ensure to follow our [Design Decisions](docs/design/README.md). -- cgit v1.2.3