From a55ff722cae338a8fcf5402858c47cf0650a8e5e Mon Sep 17 00:00:00 2001 From: Gangzheng Tong Date: Mon, 30 Jun 2025 12:11:04 -0700 Subject: Reset minimum cmake version to 3.22 (#7548) * Reset minimum cmake version to 3.22 * update slang-rhi --- CMakeLists.txt | 2 +- cmake/SlangTarget.cmake | 31 +++++++++++++++++++++++-------- docs/building.md | 2 +- external/slang-rhi | 2 +- 4 files changed, 26 insertions(+), 11 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a57b2190c..eb1c5808f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.26) +cmake_minimum_required(VERSION 3.22) # Our module dir, include that now so that we can get the version automatically # from git describe diff --git a/cmake/SlangTarget.cmake b/cmake/SlangTarget.cmake index aa87c16bf..41d77a079 100644 --- a/cmake/SlangTarget.cmake +++ b/cmake/SlangTarget.cmake @@ -414,10 +414,18 @@ function(slang_add_target dir type) # # Link and include from dependencies # - target_link_libraries( - ${target} - PRIVATE $ - ) + if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.26") + target_link_libraries( + ${target} + PRIVATE $ + ) + else() + target_link_libraries( + ${target} + PRIVATE $ + ) + endif() + target_link_libraries(${target} PUBLIC ${ARG_LINK_WITH_PUBLIC}) if(CMAKE_SYSTEM_NAME MATCHES "Darwin") @@ -458,10 +466,17 @@ function(slang_add_target dir type) endforeach() foreach(inc ${ARG_INCLUDE_DIRECTORIES_PRIVATE}) get_filename_component(inc_abs ${inc} ABSOLUTE) - target_include_directories( - ${target} - PRIVATE "$" - ) + if(CMAKE_VERSION VERSION_GREATER_EQUAL "3.26") + target_include_directories( + ${target} + PRIVATE "$" + ) + else() + target_include_directories( + ${target} + PRIVATE "$" + ) + endif() endforeach() # diff --git a/docs/building.md b/docs/building.md index 54fca8d6a..f32bda997 100644 --- a/docs/building.md +++ b/docs/building.md @@ -9,7 +9,7 @@ version of Slang. Please install: -- CMake (3.25 preferred, but 3.22 works[^1]) +- CMake (3.26 preferred, but 3.22 works[^1]) - A C++ compiler with support for C++17. GCC, Clang and MSVC are supported - A CMake compatible backend, for example Visual Studio or Ninja - Python3 (a dependency for building spirv-tools) diff --git a/external/slang-rhi b/external/slang-rhi index 6792a7ca5..753c6f84d 160000 --- a/external/slang-rhi +++ b/external/slang-rhi @@ -1 +1 @@ -Subproject commit 6792a7ca55380b08420cd5521a2aaabd287a1397 +Subproject commit 753c6f84de19d0b25382946c503770a67154e364 -- cgit v1.2.3