From a13dda4f214274a10d39f37c79622fc3e62da310 Mon Sep 17 00:00:00 2001 From: Gangzheng Tong Date: Fri, 27 Jun 2025 11:08:17 -0700 Subject: Enable Vulkan Validation Layer in CI (#7543) * Disable spirv-opt for the tests with debugfunction VVL errors * Enable VVL in CI * Add 2 expected failure tests until we update VVL to 1.4.319 which contains the fix * update slang-rhi * Revert "Disable spirv-opt for the tests with debugfunction VVL errors" This reverts commit 5327460057f533af81ea60a556e43abe805d5816. --- .github/workflows/ci.yml | 6 ++++-- external/slang-rhi | 2 +- tests/expected-failure-github.txt | 2 ++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 45e75357f..75824e3db 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -212,6 +212,8 @@ jobs: echo "Checking $api ..." && echo "$smokeResult" | grep -q "Check $api: Supported" done echo "Printing CUDA version: ..." && nvcc --version + echo "Printing Vulkan SDK version: ..." && vulkaninfo | grep -i version + fi if [[ "${{matrix.os}}" == "macos" ]] @@ -236,7 +238,7 @@ jobs: -expected-failure-list tests/expected-failure-github.txt \ -skip-reference-image-generation \ -show-adapter-info \ - -enable-debug-layers false + -enable-debug-layers true else "$bin_dir/slang-test" \ -use-test-server \ @@ -245,7 +247,7 @@ jobs: -expected-failure-list tests/expected-failure-no-gpu.txt \ -skip-reference-image-generation \ -show-adapter-info \ - -enable-debug-layers false + -enable-debug-layers true fi - name: Run Slang examples if: steps.filter.outputs.should-run == 'true' && matrix.platform != 'wasm' && matrix.full-gpu-tests diff --git a/external/slang-rhi b/external/slang-rhi index bad51b7ef..6792a7ca5 160000 --- a/external/slang-rhi +++ b/external/slang-rhi @@ -1 +1 @@ -Subproject commit bad51b7eff1d9a13c43ab16df6511463c4bc444f +Subproject commit 6792a7ca55380b08420cd5521a2aaabd287a1397 diff --git a/tests/expected-failure-github.txt b/tests/expected-failure-github.txt index 0489cafaf..0f6568997 100644 --- a/tests/expected-failure-github.txt +++ b/tests/expected-failure-github.txt @@ -14,3 +14,5 @@ tests/language-feature/shader-params/interface-shader-param-ordinary.slang.4 syn tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables.slang.8 (mtl) tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables-2.slang.3 (mtl) tests/compute/cbuffer-legalize.slang.2 syn (mtl) +tests/cooperative-vector/matrix-mul-bias-packed.slang (vk) +tests/cooperative-vector/matrix-mul-bias-packed-mut.slang (vk) \ No newline at end of file -- cgit v1.2.3