From 4f54cccf0e0e06be38312e2ee97c2b50b82d7c10 Mon Sep 17 00:00:00 2001 From: pdeayton-nv <205388607+pdeayton-nv@users.noreply.github.com> Date: Tue, 8 Jul 2025 18:26:34 -0700 Subject: Generate OpExecutionMode PointMode for tessellation shaders (#7662) * Generate "OpExecutionMode PointMode" for tessellation shaders instead of the incorrect geometry and mesh shader specific "OpExecutionMode OutputPoints". * Add a test case verifying the OpExecutionMode is correct. Fixes #7660 --- source/slang/slang-emit-spirv.cpp | 2 + tests/spirv/hull-shader-outputtopology.slang | 60 ++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+) create mode 100644 tests/spirv/hull-shader-outputtopology.slang diff --git a/source/slang/slang-emit-spirv.cpp b/source/slang/slang-emit-spirv.cpp index 7f6202a7f..28862f5b8 100644 --- a/source/slang/slang-emit-spirv.cpp +++ b/source/slang/slang-emit-spirv.cpp @@ -5312,6 +5312,8 @@ struct SPIRVEmitContext : public SourceEmitterBase, public SPIRVEmitSharedContex m = SpvExecutionModeVertexOrderCw; else if (topologyType == OutputTopologyType::TriangleCCW) m = SpvExecutionModeVertexOrderCcw; + else if (topologyType == OutputTopologyType::Point) + m = SpvExecutionModePointMode; break; } } diff --git a/tests/spirv/hull-shader-outputtopology.slang b/tests/spirv/hull-shader-outputtopology.slang new file mode 100644 index 000000000..63c279528 --- /dev/null +++ b/tests/spirv/hull-shader-outputtopology.slang @@ -0,0 +1,60 @@ +//TEST:SIMPLE(filecheck=SPIRV_POINT):-target spirv -stage hull -entry hullMain_point +//TEST:SIMPLE(filecheck=SPIRV_TRICW):-target spirv -stage hull -entry hullMain_triangle_cw +//TEST:SIMPLE(filecheck=SPIRV_TRICCW):-target spirv -stage hull -entry hullMain_triangle_ccw + +// SPIRV_POINT: OpExecutionMode %hullMain_point PointMode +// SPIRV_TRICW: OpExecutionMode %hullMain_triangle_cw VertexOrderCw +// SPIRV_TRICCW: OpExecutionMode %hullMain_triangle_ccw VertexOrderCcw + +struct Out { + float x; +}; + +struct PatchConst { + float EdgeTessFactor[4] : SV_TessFactor; + float InsideTessFactor[2] : SV_InsideTessFactor; +}; + +PatchConst patchConst() { + PatchConst o; + o.EdgeTessFactor[0] = 1; + o.EdgeTessFactor[1] = 1; + o.EdgeTessFactor[2] = 1; + o.EdgeTessFactor[3] = 1; + o.InsideTessFactor[0] = 1; + o.InsideTessFactor[1] = 1; + return o; +} + +[domain("quad")] +[partitioning("integer")] +[outputtopology("point")] +[outputcontrolpoints(4)] +[patchconstantfunc("patchConst")] +Out hullMain_point() { + Out o; + o.x = 0; + return o; +} + +[domain("quad")] +[partitioning("integer")] +[outputtopology("triangle_cw")] +[outputcontrolpoints(4)] +[patchconstantfunc("patchConst")] +Out hullMain_triangle_cw() { + Out o; + o.x = 0; + return o; +} + +[domain("quad")] +[partitioning("integer")] +[outputtopology("triangle_ccw")] +[outputcontrolpoints(4)] +[patchconstantfunc("patchConst")] +Out hullMain_triangle_ccw() { + Out o; + o.x = 0; + return o; +} -- cgit v1.2.3