From e40ddc6efb275a753a46f8c8bcc420801668c931 Mon Sep 17 00:00:00 2001 From: Copilot <198982749+Copilot@users.noreply.github.com> Date: Wed, 9 Jul 2025 16:05:22 +0000 Subject: Fix internal error when a generic in an extension is unused (#7665) * Initial plan * Add diagnostic for unreferenced generic parameters in extensions Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Use GenericTypeParamDeclBase and eliminate intermediate list Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Update test to use filecheck format for better verification Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Update extension validation to use getMembersOfType for better constraint collection Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Add temporary workaround for inheritance constraints but issue persists Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix inheritance constraint validation by moving to SemanticsDeclConformancesVisitor Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix inheritance constraint validation by removing inheritance declaration checks Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Move extension generic parameter validation back to SemanticsDeclBasesVisitor Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> * Fix test. * format code (#7671) Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> * Fix and update. * Refine fix. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: csyonghe <2652293+csyonghe@users.noreply.github.com> Co-authored-by: Yong He Co-authored-by: slangbot Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> --- .github/copilot-instructions.md | 12 +++++++++--- .github/workflows/copilot-setup-steps.yml | 2 ++ 2 files changed, 11 insertions(+), 3 deletions(-) (limited to '.github') diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 9afc79389..180478fef 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -1,8 +1,14 @@ ## Configure CMake and Build -To configure cmake, run `cmake --preset default --fresh`. -To build, run `cmake --workflow --preset debug` or `cmake --workflow --preset release`. -Build instructions can be found in docs/building.md +Slang is already built in debug configuration, so you should be able to run targets +like `slangc`, `slang-test`, `slangi` etc. right away. + +If you made some changes and need to rebuild Slang, follow these steps: + +1. Configure cmake with `cmake --preset default`. +2. Run `cmake --workflow --preset debug` to build. + +Detailed build instructions can be found in docs/building.md ## Formatting diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index fe47a7778..64dd326c7 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -30,3 +30,5 @@ jobs: run: | sudo apt-get update sudo apt-get install -y libx11-dev + cmake --preset default --fresh + cmake --workflow --preset debug -- cgit v1.2.3