From d80f4139bc4baa119a5dfcf74cdcf3a75b977efc Mon Sep 17 00:00:00 2001 From: Jay Kwak <82421531+jkwak-work@users.noreply.github.com> Date: Mon, 2 Jun 2025 16:47:16 -0700 Subject: Add a new slang-test option `-enable-debug-layers` (#7300) * Add a new slang-test option `-enable-debug-layers` A variable `disableDebugLayer` is renamed to `enableDebugLayers`, and a corresponding command-line argument is added, `-enable-debug-layers`. The previous option `-disable-debug-layer` is still available, but it prints a deprecation warning message. The reason why it is added is to make the option available to both Debug and Release. On Debug build, it will be enabled by default, and it will be disabled on Release build. We should be able to not only disable it, but also enable it on Release build. Ideally this option should be enabled all the time, but currently there are too many VUID error messages printed and we are enabling only for Debug build for now. Note that the CI/CD will run with the option disabled until we resolve all of VUID errors. --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '.github') diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 62da40295..58e5d6019 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -200,7 +200,7 @@ jobs: -expected-failure-list tests/expected-failure-record-replay-tests.txt \ -skip-reference-image-generation \ -show-adapter-info \ - ${{ matrix.config == 'debug' && '-disable-debug-layers' || '' }} + -enable-debug-layers false elif [[ "${{matrix.has-gpu}}" == "true" ]]; then "$bin_dir/slang-test" \ -use-test-server \ @@ -211,7 +211,7 @@ jobs: -expected-failure-list tests/expected-failure-github-runner.txt \ -skip-reference-image-generation \ -show-adapter-info \ - ${{ matrix.config == 'debug' && '-disable-debug-layers' || '' }} + -enable-debug-layers false else "$bin_dir/slang-test" \ -use-test-server \ @@ -222,7 +222,7 @@ jobs: -expected-failure-list tests/expected-failure-github-runner.txt \ -skip-reference-image-generation \ -show-adapter-info \ - ${{ matrix.config == 'debug' && '-disable-debug-layers' || '' }} + -enable-debug-layers false fi - name: Run Slang examples if: steps.filter.outputs.should-run == 'true' && matrix.platform != 'wasm' && matrix.full-gpu-tests -- cgit v1.2.3