Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2025-09-02T19:51:12+00:00 2025-09-02T19:51:12+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-09-02T19:51:12+00:00 urn:sha1:21693abbd0579107e3c03d1e5090b2653722b5de This commit is to emit the debug-info for the entry point parameters. Two things are implemented/fixed in this PR: - We were not emitting the `DebugVar` and `DebugValue` at the IR lowering level when the type of the entry point parameter is `ConstRef`. This commit handles the `ConstRef` case in a same way that the other types are handled so that `DebugVar` and `DebugValues` are properly emitted at the IR lowering level. - Two types for Geometry shaders were incorrectly treated as not valid types for the DebugInfo. They are `InputPatch` and `OutputPatch`. This commit handles them as valid types for DebugInfo. 2025-08-28T17:45:07+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-08-28T17:45:07+00:00 urn:sha1:c19e2e92ae8e713225262a17f39a438cd511d416 When `SIMPLE` type test is used with `-g[1-3]` option, the filecheck pattern will most likely to match to the string itself on the embedded source code rather than match to the emitted spirv-asm code. This commit avoids the problem by removing the embedded source code. This commit also provides an option to keep the embedded source code, `-preserve-embedded-source`. The source code removal is happening in two steps: 1. iterate all output lines and find SPIRV-ASM in the following pattern: `%N = OpExtInst %void %M DebugSource %fileId %sourceId`. And then, store the "%sourceId" value to identify which SPIRV instructions are for the embedded source code. 2. iterate all output lines again to find the `%sourceId = OpString "...."` and replace the whole string with the following string, ``` %1 = OpString "// slang-test removed the embedded source // Use `-preserve-embedded-source` to keep it explicitly " ``` This change revealed problems in the existing tests: - tests/bugs/spirv-debug-info.slang : The expected text was missing and it had to be added. The file also had Carrage-Return character on all lines and the pre-commit git hook removed them. - tests/spirv/debug-info.slang : the expected keyword DebugValue had to change to DebugDeclare, because that's what we get with ToT. - tests/spirv/debug-value-dynamic-index.slang : This test is currently failing, and it will pass once DebugLocalVariable instruction missing for parameter of the entry point function #7693 is resolved. --------- Co-authored-by: slangbot <ellieh+slangbot@nvidia.com> 2024-03-01T20:42:37+00:00 Yong He yonghe@outlook.com 2024-03-01T20:42:37+00:00 urn:sha1:0d01b3701aae582b5fe3b6e2c2c718bec568c741 * Various SPIRV fixes. * Fix debugValue.