Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2025-09-26T01:38:37+00:00 2025-09-26T01:38:37+00:00 aidanfnv aidanf@nvidia.com 2025-09-26T01:38:37+00:00 urn:sha1:ed5dfc550e7a0b8b685a130493faa8be198fb0a5 Fixes #7715 Updating the Vulkan SDK on the Windows CI machines to 1.4.321.1 has fixed some illegitimate VVL errors in the `cooperative-vector` tests, and #8541 has fixed some legitimate VVL errors in some of those tests, so now they can be removed from the list of expected test failures. The only expected `cooperative-vector` failures that remain are for `-emit-spriv-via-glsl`, as we do not support `GLSL_NV_cooperative_vector` yet, see #7727. 2025-09-25T17:06:29+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-09-25T17:06:29+00:00 urn:sha1:f55f669d1badc94eb4eabf77a22a5994acca7a89 It appears that the inputType of the coopvec-mat-mul cannot be signed int32. It could be floating types or signed int32. Changing the tests to use uint32 instead of int32. The spec guarantees the following combinations and the rest should be queried at the runtime if it is supported by the HW. https://registry.khronos.org/vulkan/specs/latest/man/html/VkCooperativeVectorPropertiesNV.html#_description inputType | inputInterpretation | matrixInterpretation | biasInterpretation | resultType -- | -- | -- | -- | -- FLOAT16 | FLOAT16 | FLOAT16 | FLOAT16 | FLOAT16 UINT32 | SINT8_PACKED | SINT8 | SINT32 | SINT32 SINT8 | SINT8 | SINT8 | SINT32 | SINT32 FLOAT32 | SINT8 | SINT8 | SINT32 | SINT32 FLOAT16 | FLOAT_E4M3 | FLOAT_E4M3 | FLOAT16 | FLOAT16 FLOAT16 | FLOAT_E5M2 | FLOAT_E5M2 | FLOAT16 | FLOAT16 2025-09-25T07:51:05+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-09-25T07:51:05+00:00 urn:sha1:55183716f2c8db506acd2f01330e6e21e3d9fdc7 Four WGPU tests print VVL errors. And it is preventing us from upgrading VulkanSDK on CI machines. This commit put them in the expected-failure-github.txt so that we can continue upgrading VulkanSDK. They will be re-enabled when the following issues are resolved: - https://github.com/shader-slang/slang/issues/8145 - https://github.com/shader-slang/slang/issues/8379 2025-09-25T04:49:26+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-09-25T04:49:26+00:00 urn:sha1:db44c1b732891102199f0ec9d219a33d2ab2d6a1 Related to - https://github.com/shader-slang/slang/issues/8519 2025-08-26T21:38:57+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-08-26T21:38:57+00:00 urn:sha1:1681bc67fbae57b54b66c5dcfcbf315d1efa831b fixes https://github.com/shader-slang/slang/issues/8271 This PR does the following, - Fail slang-test when there are VVL error messages. - VVL error for `gfx-unit-test-tool/` were not captured properly by the debug callback. - Set an environment variable, `VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation`, for CI and VisualStudio project setup. - Ignores VVL error about NullHandle is used for the acceleration structure; a fix is at ToT of VVL and not available from release build yet. - Fix VVL error complaining about the varying inputs are not provided for the tests, `gfx-unit-test-tool/linkTimeTypeLayout.internal` and `gfx-unit-test-tool/linkTimeTypeLayoutNested.internal`. --------- Co-authored-by: slangbot <ellieh+slangbot@nvidia.com> Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> 2025-07-27T16:57:30+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-07-27T16:57:30+00:00 urn:sha1:d311efd9d6ddc620f5960c6fc10f25daa628df6c CPU tests were invalid because CPU target doesn't support float16_t. CUDA tests were failing due to minor precision error. 2025-07-16T00:48:30+00:00 ArielG-NV 159081215+ArielG-NV@users.noreply.github.com 2025-07-16T00:48:30+00:00 urn:sha1:439e025c1d3c58cc261c36f1e8d804a403b2856a * Changes Fix a coop-vec bug, fix incorrect test synax, clean up test, comment why some coop-vec tests are stil disabled * Changes Fix a coop-vec bug, fix incorrect test synax, clean up test, comment why some coop-vec tests are stil disabled * disable failing tests * push changes * add to failing GLSL test list 2025-07-03T16:59:02+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-07-03T16:59:02+00:00 urn:sha1:279de50f9d717e5036b08e17fa937f7881f776e6 This commit removes the following test from expected-failure-github.txt because the issue is addressed on slang-rhi side. tests/compute/cbuffer-legalize.slang.2 syn (mtl) 2025-06-27T18:08:17+00:00 Gangzheng Tong tonggangzheng@gmail.com 2025-06-27T18:08:17+00:00 urn:sha1:a13dda4f214274a10d39f37c79622fc3e62da310 * Disable spirv-opt for the tests with debugfunction VVL errors * Enable VVL in CI * Add 2 expected failure tests until we update VVL to 1.4.319 which contains the fix * update slang-rhi * Revert "Disable spirv-opt for the tests with debugfunction VVL errors" This reverts commit 5327460057f533af81ea60a556e43abe805d5816. 2025-06-05T17:08:22+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-06-05T17:08:22+00:00 urn:sha1:ca0bdd238f29f2fd17ae44eec913bd6c82e0c1fe WGSL doesn't support isnan and isinf, because it assumes that it always uses fast-math and fast-math doesnt' handle NaN as defined in IEEE standard. The initial implementation used a clever workaround but it stopped working from some point. This PR implemented isnan and isinf with a bitwise operation, which can be expensive. But that seems to be an only option at the moment.