Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2024-12-31T07:39:07+00:00 2024-12-31T07:39:07+00:00 Yong He yonghe@outlook.com 2024-12-31T07:39:07+00:00 urn:sha1:cc1b96d91d8875bf727079d58fbf78af1135f505 2020-07-25T01:12:41+00:00 Tim Foley tfoleyNV@users.noreply.github.com 2020-07-25T01:12:41+00:00 urn:sha1:87940a649e3b4f757905015de95225d57ec2f27c There are two main bug fixes here: * We were failing to diagnose when code calls a `[mutating]` method on a value that doesn't support mutation (that is an r-value instead of an l-value). * We had a bug in the synthesis logic for interface requirements where we used the *result* type of the requirement in place of each of the *parameter* types. The second bug made synthesis often produce incorrect signatures with `void` parameters. The first bug meant that even though a `[mutating]` method should not be able to satisfy a non-`[mutating]` method (and we had code to enforce this for the "exact match" case), when we go on to try and synthesize a non-`[mutating]` method that satisfies the requirement by delegating to the user-written one, it would end up succeeding, because nothing was stopping a non-`[mutating]` method from calling a `[mutating]` one. In each case this code adds a fix and a test case to confirm it.