Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2025-01-07T09:35:47+00:00 2025-01-07T09:35:47+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-01-07T09:35:47+00:00 urn:sha1:5621ace93b7665051f7e7c8a2fa68ceaf285ff8d * Use disassemble API from SPIRV-Tools This commit uses C API version of SPIRV disassemble function rather than calling spirv-dis.exe. This allows us to use a correct version of SPIRV disassble function that Slangc.exe is using. The implementation is mostly copied from external/spirv-tools/tools/dis/dis.cpp, which is a source file for building spirv-dis.exe. This commit also includes a fix for a bug in RPC communication to `test-server`. When an RPC connection to `test-server.exe` is reused and the second test abruptly fails due to a compile error or SPIRV validation error, the output from the first test run was incorrectly reused as the output for the second test. This commit resets the RPC result before waiting for the response so that even when the RPC connection is erratically disconnected, the result from the previous run will not be reused incorrectly. Some of the tests appear to be relying on this type of behavior. By using an option, `-skip-spirv-validation`, the RPC connection will continue without an interruption. 2024-07-19T18:42:31+00:00 kaizhangNV 149626564+kaizhangNV@users.noreply.github.com 2024-07-19T18:42:31+00:00 urn:sha1:adf758c8c4032afcd96d995840bd697d2adef34c * Fix the issue of name mangle During our name mangling, we should add the direction of the parameter in the name, otherwise it could have the name collision which will result in invalid code generation: e.g. // in slang-module.slang export func(float a) { ...} // in test.slang extern func(inout float a); when we compile test.slang, slang will pass a pointer type to the 'func', however, in the slang-module.slang, `func` expects a value instead of pointer. This will lead the wrong spirv code. So we should add the parameter direction into the mangle name such that above two symbols will have the different mangled names, and we will catch this during IR-link stage. * Change to use to get param direction * Address few comments