Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2025-02-28T00:57:52+00:00 2025-02-28T00:57:52+00:00 Yong He yonghe@outlook.com 2025-02-28T00:57:52+00:00 urn:sha1:6f2ce72b038b34e84819ddfc5d658166ed879eaa * Map `SV_InstanceID` to `gl_InstanceIndex-gl_BaseInstance` * Fix ci. 2024-08-22T11:23:05+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2024-08-22T11:23:05+00:00 urn:sha1:a3fbd8f060317332eae951d4a376e830d058469e * Fix a false failure when using the latest SPIR-V --------- Co-authored-by: Ellie Hermaszewska <github@sub.monoid.al> Co-authored-by: ArielG-NV <159081215+ArielG-NV@users.noreply.github.com> Co-authored-by: Ellie Hermaszewska <ellieh@nvidia.com> 2024-06-13T23:12:42+00:00 ArielG-NV 159081215+ArielG-NV@users.noreply.github.com 2024-06-13T23:12:42+00:00 urn:sha1:2407966e899f9e4f490b23a92fc06d5da20544cc * solve issue by making 'non SV for SPIRV' system semantics, no longer an SV once diagnosed by slang Problem: 1. SV_InstanceID (HLSL) is allowed as an output semantic with HLSL, it is also allowed for input into pixel shader. We need to account for multiple entry points in 1 file using both of these scenarios at once. 2. SPIRV does not allow `SV_InstanceID` as a builtin, `SV_InstanceID` must be passed as a regular `flat` `Input` from vertex shader. Solution: Slang needs to treat these SV objects as non built-in's. As a result: 1. Slang needs to allocate for vertex output and fragment Input binding slots for all SV_InstanceID uses (if the target is SPIRV). This allows Slang to prepare an open slot to bind these SV objects to. 2. Slang needs to not emit built in modifier for these not actual built in variables (under the specific circumstances described). note: `VarLayout` was made not `HOISTABLE` since I don't believe it needs to be `HOISTABLE`. * The code can be made to work even if `VarLayout` is `HOISTABLE`. * fix compile warnings * address review comments and reimplement operand removal 1. remove an operand by selectively copying operands 2. test to ensure `Flat` is in the test shaders * we do not need to manually add `Flat` in the code since this is done for us in emit-spirv. This is the behavior since `uint` on a fragment `Input` must be `Flat`, else it is a VK validation error. * address review remove clone logic * address review remove unused function reserve instead of setCount with ShortList