Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2019-01-15T21:15:09+00:00 2019-01-15T21:15:09+00:00 Tim Foley tfoleyNV@users.noreply.github.com 2019-01-15T21:15:09+00:00 urn:sha1:29ffac963e9c4b02d3cbc9d4b281512ed820e67d The logic in `check.cpp` for declaration checking is very messy and needs to be re-written, but in the interim we need to be careful to avoid any cases where a declaration, or some piece of it, gets redundantly checked multiple times. The way the logic had been working, the different "cases" in an `enum` type were being checked twice, and that meant that any initialization expression for a case would be type-checked the first time (potentially leading to a new AST) and then the checked AST would be checked again. This created a problem if the first round of checking introduced any AST nodes that the checking logic would not expect to see (because the parser cannot possibly produce them). The fix here is to follow the style of the other declaration checking cases, where checking is separated into two distinct phases (the "header" phase makes the declaration usable by others, while the "body" phase checks its implementation details for internal consistency). This change includes a test case that produced an internal compiler error before, and compiles without error now.