slang.git/source/slang/slang-serialize-ir-types.cpp, branch masterMaking it easier to work with shadershttps://git.yummers.dev/slang.git/atom?h=master2025-04-16T19:28:39+00:00Remove support for ad hoc Slang IR compression (#6834)2025-04-16T19:28:39+00:00Theresa Foley10618364+tangent-vector@users.noreply.github.com2025-04-16T19:28:39+00:00urn:sha1:2b20e9e150225f8cb75f7be2061f5ec99cbb2f66
* Remove support for ad hoc Slang IR compression
This change is part of a larger effort to clean up the approach to
serialization in the Slang compiler. The overall goal is to simplify
and streamline all of the serialization-related logic, so that we are
left with code that is less "clever," and easier to understand for
contributors to the codebase.
Removing support for compression of serialized Slang IR has
benefits that include:
* Reduction in code complexity: consider things like the subtle way
that the `FOURCC`s for compressed chunks were being computed from
the uncompressed versions, and the mental overhead that goes into
understanding that, for anybody who would dare to touch this code.
* Reduction in testing burden: there have been, de facto, two
very different code paths for serialization of the Slang IR, and
it is not clear that the existing test corpus for Slang has
sufficient coverage for both options. By having only a single code
path, every test that performs any amount of IR serialization helps
with test coverage of that one path.
* Opportunity to explore alternatives. This is perhaps a reiteration
of the first point, but once the code is stripped down to the
simplest thing that could possibly work (I am not claiming it has
reached that point yet), it becomes easier for contributors to
understand, and it becomes more tractable for somebody to come along
with an improved approach that performs better (in either
compression ratio or performance) while still being maintainable.
In my own local setup, I found that removing support for Slang IR
compression led to the `slang-core-module-generated.h` file increasing
in size from 46.1MB to 47.4MB. This increase in the `.h` file size
for the core library binary only resulted in a release build of
`slang.dll` increasing from 20.0MB to 20.2MB. Removing the ad hoc
compression support has almost no impact on the size of actual binary
Slang modules *so long* as the additional LZ4 compression step is
being applied to them.
* format code
---------
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>format2024-10-29T06:49:26+00:00Ellie Hermaszewskaellieh@nvidia.com2024-10-29T06:49:26+00:00urn:sha1:f65d756bff8d4c5cbc15bd0322a2ae8e6b896a21
* format
* Minor test fixes
* enable checking cpp format in ciShare debug information between AST and IR (#1547)2020-09-17T20:47:57+00:00jsmall-nvidiajsmall@nvidia.com2020-09-17T20:47:57+00:00urn:sha1:b9cddcb9c718f986ee5e4f7c6189ee2ebea4ace1
* Test if blob is returned.
* Rename serialize files so can be grouped.
* StringRepresentationCache -> SerialStringTable
* Split out SerialStringTable from slang-serialize-ir
* First pass at reorganizing serialization/containers. Remain some issues about debug info.
* Fix bug in calculating sourceloc.
* Improve calcFixSourceLoc
* Make allocations for payload RiffContainer align to at least 8 bytes. This is important for read, if the payload can contain 8 byte aligned data. Note this has no effect on Riff file format alignment rules.
* Improve comments around RiffContainer and alignment.
* Remove SerialStringTable, can just use StringSlicePool instead.
* Typo fix for Clang/Linux.
Co-authored-by: Tim Foley <tfoleyNV@users.noreply.github.com>