Making it easier to work with shaders https://git.yummers.dev/slang.git/atom?h=master 2025-10-03T04:48:11+00:00 2025-10-03T04:48:11+00:00 Theresa Foley 10618364+tangent-vector@users.noreply.github.com 2025-10-03T04:48:11+00:00 urn:sha1:cc8f6a241edb47c43c5698ee33abed4fe57d4566 Note that while this change touched a large numer of files, there are no changes to functionality being made here. The only things being done are renaming various symbols and, in a few cases, updating or adding comments for consistency with the new names. The core of the naming changes are: * Most things named to refer to `OutType` (e.g., `IROutType`, `IRBuilder::getOutType()`, etc.) have been consistently renamed to refer to `OutParamType`, to emphasize that the relevant AST/IR node types are only intended for use to represent `out` parameters. * The same change as described above for `OutType` is also made for `RefType`, which becomes `RefParamType` in most cases. One mess that this exposes is the way that the `ExplicitRef<T>` type in the core module currently lowers to `IRRefParamType`. This change sticks to the rule of not making functional changes, so that mess is left as-is for now. * Names referring to `InOutType` have been changed to instead refer to `BorrowInOutType`. The intention with this naming change is to emphasize that the Slang rules for `inout` are semantically those of a borrow (or at least our interpretation of what a borrow means). * Names referring to `ConstRefType` have been changed to instead refer to `BorrowInType`. This change starts work on clarifying that the existing `__constref` modifier was never intended to be a read-only analogue of `__ref`, and instead is the input-only analogue of `inout`. * The `ParameterDirection` enum type has been changed to `ParamPassingMode`, to reflect the fact that the concept of "direction" fails to capture what is actually being encoded, particularly once we have modes beyond simple `in`/`out`/`inout`. While this change does not alter behavior in any case (the user-exposed Slang language is unchanged), it is intended to set up subsequence changes that will work to make the handling of these types in the compiler more nuanced and correct. Breaking this part of the change out separately is primarily motivated by a desire to minimize the effort for reviewers. --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> 2025-10-02T22:24:46+00:00 kaizhangNV 149626564+kaizhangNV@users.noreply.github.com 2025-10-02T22:24:46+00:00 urn:sha1:0c778339d7e3c39f600af2cc049f13f661d3434b Close #8572. The root cause of the issue is that in `_replaceInstUsesWith` call, if the use of the inst is a generic parameter, and the inst is the data type of that generic parameter, we could end up of moving the data type before the generic parameter. This will break the layout of generic parameters, where all the generic parameters should be laid consecutively at the beginning of the first block of the generic. Therefore, we don't make that relocation for such case. 2025-09-03T20:05:26+00:00 Ellie Hermaszewska ellieh@nvidia.com 2025-09-03T20:05:26+00:00 urn:sha1:a766d27447aa0fcf69334c0467d9b1124892e180 closes https://github.com/shader-slang/slang/issues/3313 2025-07-18T16:38:00+00:00 venkataram-nv vedavamadath@nvidia.com 2025-07-18T16:38:00+00:00 urn:sha1:48b6e2432ea28c06d04931fccd633e31eed6d995 * Add tests for expected behaviour * Allow matrix types in logical or/and * Legalize int/bool matrix types and construction with makeMatrix * Legalize uint matrices and operations * Limit testing to only SPIRV * Better tests for int and bool * Add test for uint * Remove GLSL tests * Remove old test for diagnosing int matrices * Emit SPIRV directly in tests * format code * Address PR comments * Improve testing * Address PR comments * format code * Add tests for matrix intrinsic operations * Move matrix lowering to dedicated legalization pass * Fix compiler warning * Remove signal again * Reorder matrix and vector legalization * Fix formatting * Add shift and comparison tests --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> 2025-07-01T19:03:41+00:00 Ellie Hermaszewska ellieh@nvidia.com 2025-07-01T19:03:41+00:00 urn:sha1:5120c1cd072548654c9ce79fa85426a5e48736c4 * Add fkYAML submodule * Generate slang-ir-inst-defs.h from slang-ir-inst-defs.yaml * generate ir-inst-defs.h * neaten things * neaten inst def parser * add rapidyaml submodule * remove fkyaml * remove fkyaml submodule * remove use of ir-inst-defs.h * format and warnings * fix wasm build * tidy * remove rapidyaml * Extend fiddle to allow custom splices in more places * Use lua to describe ir insts * fix * neaten * neaten * neaten * spelling * neaten * comment comment out assert * merge 2025-06-12T05:33:16+00:00 Jay Kwak 82421531+jkwak-work@users.noreply.github.com 2025-06-12T05:33:16+00:00 urn:sha1:7dad68f869502e5c0ab32c12cbf8db866e020713 This PR replaces enable/disable style C function calls with C++ RAII style code. In debug build, when an assertion failed in between enable and disable functions, an exception is thrown and the disable function is not called. RAII style code is safer for an exception 2025-05-14T07:01:47+00:00 Darren Wihandi 65404740+fairywreath@users.noreply.github.com 2025-05-14T07:01:47+00:00 urn:sha1:eb5648b41d0718648477cbcf941fb3c6edf6dfc7 * Error out on invalid vector sizes * Remove unnecessary include * Fix incorrect assert * Add test 2025-05-10T20:59:37+00:00 Mukund Keshava mkeshava@nvidia.com 2025-05-10T20:59:37+00:00 urn:sha1:083eecee3f56b90c7011895f53aaafa9db15856e 2025-01-22T17:10:35+00:00 Anders Leino aleino@nvidia.com 2025-01-22T17:10:35+00:00 urn:sha1:04353fb7602b7eb6a8b86193510ebe0c670b7724 * Reimplement the GLSL atomic* functions in terms of __intrinsic_op Many of these functions map directly to atomic IR instructions. The functions taking atomic_uint are left as they are. This helps to address #5989, since the destination pointer type validation can then be written only for the atomic IR instructions. * Add validation for atomic operations Diagnose an error if the destination of the atomic operation is not appropriate, where appropriate means it's either: - 'groupshared' - from a device buffer This closes #5989. * Add tests for GLSL atomics destination validation Attempting to use the GLSL atomic functions on destinations that are neither groupshared nor from a device buffer should fail with the following error: error 41403: cannot perform atomic operation because destination is neither groupshared nor from a device buffer. * Validate atomic operations after address space specialization Address space specialization for SPIR-V is not done as part of `linkAndOptimizeIR`, as it is for e.g. Metal, so opt out and add a separate call for SPIR-V. * Allow unchecked in/inout parameters for non-SPIRV targets * Clean up callees left without uses during address space specialziation * format code --------- Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com> Co-authored-by: Yong He <yonghe@outlook.com> 2024-11-05T17:47:26+00:00 Ellie Hermaszewska ellieh@nvidia.com 2024-11-05T17:47:26+00:00 urn:sha1:b118451e301d734e3e783b3acdf871f3f6ea851c * Move switch statement bodies to their own lines * format --------- Co-authored-by: Yong He <yonghe@outlook.com>